Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom equality testers #705

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ori-moisis
Copy link

@ori-moisis ori-moisis commented Dec 1, 2024

What

Custom equality testers were added to jest in version 29.4.0 - jestjs/jest#13654
This was done in a way that requires custom matchers to explicitly pass them to use the equals method.

Why

Adding this to all relevant matchers so they will respect any custom equality testers that were added to jest

Notes

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Typescript definitions are added/updated where relevant

Custom equality testers were added to jest in version 29.4.0.
This was done in a way that requires custom matchers to explicitly pass them to use the equals method.

Adding this to all relevant matchers so they will respect any custom equality testers that were added to jest
Copy link

changeset-bot bot commented Dec 1, 2024

🦋 Changeset detected

Latest commit: f3751f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
jest-extended Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ori-moisis added a commit to ori-moisis/salto that referenced this pull request Dec 2, 2024
…equality testers

Use a version of jest-extended that contains the changes from this PR - jest-community/jest-extended#705
ori-moisis added a commit to ori-moisis/salto that referenced this pull request Dec 3, 2024
…equality testers

Use a version of jest-extended that contains the changes from this PR - jest-community/jest-extended#705
ori-moisis added a commit to salto-io/salto that referenced this pull request Dec 3, 2024
…equality testers (#6880)

Use a version of jest-extended that contains the changes from this PR - jest-community/jest-extended#705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant